fix(uart): Fixes UART CI script to work with Arduino Core 3.2.x #11077

SuGlider · 2025-03-12T01:28:53Z

Description of Change

Fixes the UART CI script to work correctly with Arduino Core 3.1.2+ / 3.2.x

Tests scenarios

Related links

None

github-actions · 2025-03-12T01:29:34Z

	Messages
📖	🎉 Good Job! All checks are passing!

👋 Hello SuGlider, we appreciate your contribution to this project!

📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...

This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...

We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 293d0bf

github-actions · 2025-03-12T01:39:03Z

Test Results

76 files 76 suites 12m 49s ⏱️
38 tests 36 ✅ 0 💤 2 ❌
241 runs 239 ✅ 0 💤 2 ❌

For more details on these failures, see this check.

Results for commit 293d0bf.

♻️ This comment has been updated with latest results.

lucasssvaz · 2025-03-15T16:58:08Z

Is ESP32 test also supposed to pass ?

SuGlider · 2025-03-16T13:23:36Z

Is ESP32 test also supposed to pass ?

Yes. It works with the real device. It just fails with Wokwi.

-The sketch with the ESP32 and Wokwi reports 2 fails, but if I comment out the Line 56 [pinMode()], it doesn't fail:

/tmp/hexi-esp32:esp32:esp32/sketch/sketch.ino:80:basic_transmission_test:FAIL: Expected 'Hello from Serial1 ' Was ''
/tmp/hexi-esp32:esp32:esp32/sketch/sketch.ino:450:periman_test:FAIL: Expected '' Was '\xE0'
Change pins test successful

Using the Real ESP32 device, it reports NO Fail, but if I comment out the same Line 56, it reports 2 different Fails:

C:\Users\esp\Documents\Arduino\CI_HardwareSerial_test\CI_HardwareSerial_test.ino:80:periman_test:FAIL: Expected 'Hello from Serial2 while I2C is disabled' Was ''
C:\Users\esp\Documents\Arduino\CI_HardwareSerial_test\CI_HardwareSerial_test.ino:80:change_pins_test:FAIL: Expected 'Hello from Serial1 using new pins' Was ''

Wokwi ESP32 fails with the pinMode() in line 56|58 Real device with Arduino Core 3.1.2 and 3.2 needs it to fix the issue. This patch will skip the pinMode() when compiling with Wokwi and make it pass the CI test case.

…ference

SuGlider · 2025-03-16T14:45:58Z

@lucasssvaz - Wokwi reports different CI test results than the real ESP32 device.

Is there any way to detect that it is running on Wokwi and skip the part of the code (pinMode() Line 56)?
Something like #ifdef WOKWI...
It would be a work around for Wokwi.... not sure if this something wishful.

SuGlider · 2025-03-16T15:07:50Z

@lucasssvaz - I have found out that Wokwi runs Arduino Core 3.1.1. The target of this patch is for Core 3.1.2 onwards. That may explain the issue with ESP32 and Wokwi.

Note: using Arduino Core 3.1.1 + ESP32, it won't fail in the Real Device... only Wokwi fails.

lucasssvaz · 2025-03-16T18:19:08Z

@lucasssvaz - I have found out that Wokwi runs Arduino Core 3.1.1. The target of this patch is for Core 3.1.2 onwards. That may explain the issue with ESP32 and Wokwi.

Note: using Arduino Core 3.1.1 + ESP32, it won't fail in the Real Device... only Wokwi fails.

Wokwi runs the binaries we compile, in this case 3.2.0. Wokwi online editor has fixed versions like this but its not our case.

Anyway, if it works in the actual hardware. That's what matters. I will report to Uri.

lucasssvaz · 2025-03-17T03:01:27Z

@SuGlider Can you test wokwi locally with the changes I pushed to see if it works ?

SuGlider · 2025-03-17T03:44:42Z

@SuGlider Can you test wokwi locally with the changes I pushed to see if it works ?

No, it also fails locally.

/tmp/hexi-esp32:esp32:esp32/sketch/sketch.ino:453:periman_test:FAIL: Expected '' Was '\xFF'
Change pins test successful
/tmp/hexi-esp32:esp32:esp32/sketch/sketch.ino:557:change_pins_test:PASS
End when stopped test successful
/tmp/hexi-esp32:esp32:esp32/sketch/sketch.ino:558:end_when_stopped_test:PASS

-----------------------
11 Tests 1 Failures 0 Ignored

failing CI, missed the comments

SuGlider added 3 commits March 11, 2025 21:17

fix(uart): ci uart test fail on esp32s2 after uart break

f2bc23d

fix(uart): ci error with change pins test on ESP32

d3f51ee

fix(uart): ci test with perimgr using esp32 fails

7e75bba

SuGlider added Type: CI & Testing Peripheral: UART labels Mar 12, 2025

SuGlider added this to the 3.2.0 milestone Mar 12, 2025

SuGlider self-assigned this Mar 12, 2025

SuGlider added this to Arduino ESP32 Core Project Roadmap Mar 12, 2025

github-project-automation bot moved this to Todo in Arduino ESP32 Core Project Roadmap Mar 12, 2025

SuGlider moved this from Todo to In Progress in Arduino ESP32 Core Project Roadmap Mar 12, 2025

feat(uart): avoid electrical noise before setting pins

e6a0b20

SuGlider marked this pull request as draft March 12, 2025 01:56

SuGlider added 3 commits March 14, 2025 17:10

fix(uart_ci): fixes the UART CI sketch due to IDF 5.3 pull up change

6be85a3

fix(uart_ci): keeping previous formatting and applying changes

28564ea

Merge branch 'master' into fix/uart_ci_test

f1412d6

SuGlider marked this pull request as ready for review March 14, 2025 20:25

SuGlider moved this from In Progress to In Review in Arduino ESP32 Core Project Roadmap Mar 14, 2025

SuGlider added the Status: Review needed Issue or PR is awaiting review label Mar 14, 2025

SuGlider requested review from lucasssvaz, me-no-dev and P-R-O-C-H-Y March 14, 2025 20:26

me-no-dev approved these changes Mar 14, 2025

View reviewed changes

SuGlider added 2 commits March 16, 2025 11:15

feat(uart_ci): trick for passing esp32 wokwi ci test

6b2965d

Wokwi ESP32 fails with the pinMode() in line 56|58 Real device with Arduino Core 3.1.2 and 3.2 needs it to fix the issue. This patch will skip the pinMode() when compiling with Wokwi and make it pass the CI test case.

feat(uart_ci): reverting the wokwi patch, once it didn't make any dif…

9ea4051

…ference

fix(wokwi): Change CPU freq to 80

e27dcc3

P-R-O-C-H-Y previously approved these changes Mar 17, 2025

View reviewed changes

lucasssvaz and others added 2 commits March 17, 2025 10:14

fix(wokwi): Change CPU freq to 120

c8f54f9

Merge branch 'master' into fix/uart_ci_test

f89af6c

lucasssvaz added the Status: Pending Merge Pull Request is ready to be merged label Mar 17, 2025

lucasssvaz approved these changes Mar 17, 2025

View reviewed changes

pre-commit-ci-lite bot and others added 2 commits March 17, 2025 13:32

ci(pre-commit): Apply automatic fixes

a304ea1

fix(uart_ci): fixes a couple typos in commentatries

293d0bf

me-no-dev merged commit 74ee9df into master Mar 17, 2025
25 of 28 checks passed

github-project-automation bot moved this from In Review to Done in Arduino ESP32 Core Project Roadmap Mar 17, 2025

me-no-dev deleted the fix/uart_ci_test branch March 17, 2025 15:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(uart): Fixes UART CI script to work with Arduino Core 3.2.x #11077

fix(uart): Fixes UART CI script to work with Arduino Core 3.2.x #11077

SuGlider commented Mar 12, 2025 •

edited

Loading

github-actions bot commented Mar 12, 2025 •

edited

Loading

github-actions bot commented Mar 12, 2025 •

edited

Loading

lucasssvaz commented Mar 15, 2025

SuGlider commented Mar 16, 2025 •

edited

Loading

SuGlider commented Mar 16, 2025 •

edited

Loading

SuGlider commented Mar 16, 2025 •

edited

Loading

lucasssvaz commented Mar 16, 2025

lucasssvaz commented Mar 17, 2025

SuGlider commented Mar 17, 2025

fix(uart): Fixes UART CI script to work with Arduino Core 3.2.x #11077

fix(uart): Fixes UART CI script to work with Arduino Core 3.2.x #11077

Conversation

SuGlider commented Mar 12, 2025 • edited Loading

Description of Change

Tests scenarios

Related links

github-actions bot commented Mar 12, 2025 • edited Loading

github-actions bot commented Mar 12, 2025 • edited Loading

Test Results

lucasssvaz commented Mar 15, 2025

SuGlider commented Mar 16, 2025 • edited Loading

Yes. It works with the real device. It just fails with Wokwi.

SuGlider commented Mar 16, 2025 • edited Loading

SuGlider commented Mar 16, 2025 • edited Loading

lucasssvaz commented Mar 16, 2025

lucasssvaz commented Mar 17, 2025

SuGlider commented Mar 17, 2025

SuGlider commented Mar 12, 2025 •

edited

Loading

github-actions bot commented Mar 12, 2025 •

edited

Loading

github-actions bot commented Mar 12, 2025 •

edited

Loading

SuGlider commented Mar 16, 2025 •

edited

Loading

SuGlider commented Mar 16, 2025 •

edited

Loading

SuGlider commented Mar 16, 2025 •

edited

Loading